kriegaex edited a comment on pull request #104: URL: https://github.com/apache/maven-shade-plugin/pull/104#issuecomment-883970310
In that case, both #108 and my additional, local commits on top of this PR, both adding directory handling to minification, should not be merged, because it would be unused code. The only case in which a directory needs to be handled at all is self-minification. Then we are back to square 1, and I suggest to **merge this PR as-is,** because at least until you do the "grand refactoring" for the next major, it does the right thing for the self-directory, not logging the ugly warning. BTW, this morning (local time in Asia) I was surprised to see that someone created a 3.3.0 release already, but have not seen it on Central or on the plugin Maven site yet. But probably releasing a 3.3.1 with both this PR and my other PR concerning improved source code filtering would be a good idea. Alternative to merge as-is: A simple way of self-minification, which could be implemented without too much hassle until you do the "grand refactoring", would be to add two specific options such as `minifySelf` and a list of `minifySelfEntryPoints` with the same syntax as `includes` (e.g. `<minifySelfEntryPoint>org/acme/**/*Application.class</minifySelfEntryPoint>`. (Never mind the option names, we can change them.) Then we would have enough information to populate `MinijarFilter.removable` and get a simple version of self-minification running, including correct handling of services. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
