pzygielo commented on a change in pull request #8:
URL:
https://github.com/apache/maven-resolver-ant-tasks/pull/8#discussion_r720787401
##########
File path: src/main/java/org/apache/maven/resolver/internal/ant/AntRepoSys.java
##########
@@ -649,11 +649,10 @@ private Properties getEnvProperties( Properties props )
{
props = new Properties();
}
- boolean envCaseInsensitive = OS_WINDOWS;
for ( Map.Entry<String, String> entry : System.getenv().entrySet() )
{
String key = entry.getKey();
- if ( envCaseInsensitive )
+ if ( OS_WINDOWS )
Review comment:
But previously the code would suggest we are interested in environment
being or not case insensitive. But now it's only about being Windows. I think
the readability is lowered now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
