pzygielo commented on a change in pull request #8: URL: https://github.com/apache/maven-resolver-ant-tasks/pull/8#discussion_r720826164
########## File path: src/main/java/org/apache/maven/resolver/internal/ant/AntRepoSys.java ########## @@ -649,11 +649,10 @@ private Properties getEnvProperties( Properties props ) { props = new Properties(); } - boolean envCaseInsensitive = OS_WINDOWS; for ( Map.Entry<String, String> entry : System.getenv().entrySet() ) { String key = entry.getKey(); - if ( envCaseInsensitive ) + if ( OS_WINDOWS ) Review comment: > Don't you think would be better a comment in the code explaining the use case? No, I don't. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org