cstamas commented on a change in pull request #38:
URL: https://github.com/apache/maven-plugin-tools/pull/38#discussion_r721604869
##########
File path:
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -204,6 +204,25 @@ public void execute()
+ "In the future this error will break the
build.\n\n" );
}
+ Set<Artifact> wrongScopedArtifacts =
mavenDependenciesNotInProvidedScope();
+ if ( !wrongScopedArtifacts.isEmpty() )
+ {
+ StringBuilder errorMessage = new StringBuilder(
+ "\n\nMaven dependencies of Maven Plugins should be in provided
scope.\n"
+ + "Please make sure that all your dependencies declared in
POM having Group Id of\n"
+ + "org.apache.maven have set '<scope>provided</scope>' as
well.\n"
+ + "In the future this error will break the build.\n\n"
+ + "Following dependencies are in wrong scope:\n"
Review comment:
fixed
##########
File path:
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -204,6 +204,25 @@ public void execute()
+ "In the future this error will break the
build.\n\n" );
}
+ Set<Artifact> wrongScopedArtifacts =
mavenDependenciesNotInProvidedScope();
+ if ( !wrongScopedArtifacts.isEmpty() )
+ {
+ StringBuilder errorMessage = new StringBuilder(
+ "\n\nMaven dependencies of Maven Plugins should be in provided
scope.\n"
+ + "Please make sure that all your dependencies declared in
POM having Group Id of\n"
Review comment:
fixed
##########
File path:
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -294,6 +313,25 @@ static String getDefaultGoalPrefix( MavenProject project )
return defaultGoalPrefix;
}
+ /**
+ * Collects all dependencies having {@code org.apache.maven} group Id that
are NOT in provided scope.
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
