cstamas commented on a change in pull request #38:
URL: https://github.com/apache/maven-plugin-tools/pull/38#discussion_r725114382
##########
File path:
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -204,6 +204,25 @@ public void execute()
+ "In the future this error will break the
build.\n\n" );
}
+ Set<Artifact> wrongScopedArtifacts =
mavenDependenciesNotInProvidedScope();
+ if ( !wrongScopedArtifacts.isEmpty() )
+ {
+ StringBuilder errorMessage = new StringBuilder(
+ "\n\nMaven dependencies of Maven Plugins should be in provided
scope.\n"
+ + "Please make sure that all your dependencies declared in
POM whose group ID is\n"
+ + "org.apache.maven have set '<scope>provided</scope>' as
well.\n"
+ + "In the future this error will break the build.\n\n"
+ + "The following dependencies are in wrong scope:\n"
+ );
+ for ( Artifact artifact : wrongScopedArtifacts )
+ {
+ errorMessage.append( " * " ).append( artifact ).append( "\n" );
Review comment:
While I agree, I mimicked the message one above, that also uses `\n` and
is unrelated to this change. IMO, we should clean these up in separate PR if
really needed, as if I fix this message only, thing will be even worse, as then
mixed line endings will be emitted to console (if both warnings triggered for
example).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
