rmannibucau commented on a change in pull request #565:
URL: https://github.com/apache/maven/pull/565#discussion_r724859141
##########
File path: maven-core/src/main/java/org/apache/maven/execution/MavenSession.java
##########
@@ -192,11 +194,12 @@ public MavenExecutionResult getResult()
// Backward compat
- public Map<String, Object> getPluginContext( PluginDescriptor plugin,
MavenProject project )
+ public ConcurrentMap<String, Object> getPluginContext( PluginDescriptor
plugin, MavenProject project )
Review comment:
Not sure since the JVM looks up the methods using the return type too so
depending the version you compiled against it will fail. Since java 8 the Map
exposes the interesting pieces of ConcurrentMap so think it is saner to use
java 8 as base and stick on Map for backward compat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
