cstamas commented on a change in pull request #565:
URL: https://github.com/apache/maven/pull/565#discussion_r725448397
##########
File path: maven-core/src/main/java/org/apache/maven/execution/MavenSession.java
##########
@@ -192,11 +199,20 @@ public MavenExecutionResult getResult()
// Backward compat
+ /**
+ * Returns the plugin context for given key ({@link
PluginDescriptor#getPluginLookupKey()} and
+ * {@link MavenProject}, never returns {@code null} as if context not
present, creates it.
+ *
+ * <strong>Implementation note:</strong> while this method return type is
{@link Map}, the returned map instance
+ * implements {@link ConcurrentMap} as well.
+ *
+ */
public Map<String, Object> getPluginContext( PluginDescriptor plugin,
MavenProject project )
Review comment:
I completely agree with your assessment, but that change would be not
part of "Mojo API update proposal", would it? IMHO, it deserves another JIRA
and PR, as the code you mention is unchanged by this PR (it had only Map vs
ConcurrentMap change that is partially undone)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
