rmannibucau commented on a change in pull request #565: URL: https://github.com/apache/maven/pull/565#discussion_r731752049
########## File path: maven-core/src/main/java/org/apache/maven/plugin/internal/MojoLogFactory.java ########## @@ -0,0 +1,46 @@ +package org.apache.maven.plugin.internal; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import javax.inject.Named; +import javax.inject.Singleton; + +import org.apache.maven.plugin.logging.Log; +import org.slf4j.LoggerFactory; + +/** + * Implementation of Mojo {@link Log} factory backed by Maven internal logging (slf4j). + * + * @since TBD + */ +@Singleton +@Named +public class MojoLogFactory Review comment: Think a threadlocal solution does not work since a lot of mojo are multithreaded so, until we replace through the ClassRealm the `new Thread` with a `new MavenThread` which can propagate a context and rely on some MDC I think we have to fallback on a class realm anyway. Only limitation is to log a particular execution - and I think it is fine - so long story short, I would align log factory on classloaders (maybe with the exception of extensions which would inherit from maven core config but it is by design). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
