slawekjaranowski commented on a change in pull request #104:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/104#discussion_r734984105
##########
File path:
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -5543,12 +5543,10 @@ private ResolvePathResult getResolvePathResult( File
artifactFile )
}
catch ( IOException | RuntimeException /* e.g
java.lang.module.FindException */ e )
{
- Throwable cause = e;
- while ( cause.getCause() != null )
+ if ( getLog().isDebugEnabled() )
{
- cause = cause.getCause();
+ getLog().debug( "resole path for: " + artifactFile + " cause
error: " + e.getMessage(), e );
Review comment:
Implementation in plexus-java for jdk < 9 is:
https://github.com/codehaus-plexus/plexus-languages/blob/e1450e99c53e45a4935f4bd65b4349877d6cdbb1/plexus-java/src/main/java/org/codehaus/plexus/languages/java/jpms/CmdModuleNameExtractor.java#L44-L47
What is your proposition for code here?
we can provide some message for `UnsupportedOperationException` in
plexus-java ... but logging warn here is too talkative, it look like standard
flow for detecting modules support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
