rfscholte commented on a change in pull request #104:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/104#discussion_r734986404
##########
File path:
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -5543,12 +5543,10 @@ private ResolvePathResult getResolvePathResult( File
artifactFile )
}
catch ( IOException | RuntimeException /* e.g
java.lang.module.FindException */ e )
{
- Throwable cause = e;
- while ( cause.getCause() != null )
+ if ( getLog().isDebugEnabled() )
{
- cause = cause.getCause();
+ getLog().debug( "resole path for: " + artifactFile + " cause
error: " + e.getMessage(), e );
Review comment:
The problem is that if there's no module descriptor nor Manifest file
with an Automatic-Module-Name, you need Java 9 code to get the module name
based on the filename. So you must set in JdkHome in the request if you're not
running with Java 9+.
The plugin is responsible to set this up correctly.
IIRC due to a recent change this method became exposed, otherwise it would
never occur. So better to improve the message of the exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
