eolivelli commented on a change in pull request #601:
URL: https://github.com/apache/maven/pull/601#discussion_r735075372
##########
File path: maven-core/src/main/java/org/apache/maven/project/MavenProject.java
##########
@@ -951,7 +951,7 @@ public void addAttachedArtifact( Artifact artifact )
{
attachedArtifacts = new ArrayList<>();
}
- return Collections.unmodifiableList( attachedArtifacts );
+ return attachedArtifacts;
Review comment:
If we want to let this result be modified by the caller I would add a
comment/javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
