garydgregory commented on a change in pull request #601:
URL: https://github.com/apache/maven/pull/601#discussion_r735106745
##########
File path: maven-core/src/main/java/org/apache/maven/project/MavenProject.java
##########
@@ -951,7 +951,7 @@ public void addAttachedArtifact( Artifact artifact )
{
attachedArtifacts = new ArrayList<>();
}
- return Collections.unmodifiableList( attachedArtifacts );
+ return attachedArtifacts;
Review comment:
Err... maybe the Javadoc should have been updated when the method was
changed to change the collection from mutable to immutable, but, the method has
zero Javadoc to begin with, so not a great way to lead by example ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
