gnodet commented on a change in pull request #584:
URL: https://github.com/apache/maven/pull/584#discussion_r761500582
##########
File path:
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java
##########
@@ -55,9 +56,7 @@
private static final String DEFAULT_LANGUAGE = "java";
- private List<Parameter> parameters;
-
- private Map<String, Parameter> parameterMap;
+ private final ArrayList<Parameter> parameters;
Review comment:
It leads to think that the chosen implementation is actually important,
which isn't really the case and any `List` implementation should work. Looser
coupling of some kind.
No big deal though, I certainly won't veto for such minor and arguable
things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
