cstamas commented on a change in pull request #584:
URL: https://github.com/apache/maven/pull/584#discussion_r761504352
##########
File path:
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java
##########
@@ -55,9 +56,7 @@
private static final String DEFAULT_LANGUAGE = "java";
- private List<Parameter> parameters;
-
- private Map<String, Parameter> parameterMap;
+ private final ArrayList<Parameter> parameters;
Review comment:
Agreed :smile: But re "leads to think" IMHO quite the opposite:
ArrayList is the "first java list impl that comes to mind", so to say, I would
raise eye-browse if I'd see there some non-common List implementation. By
clearly stating ArrayList, I think am telling "literally any list would do",
same thing you say.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
