ibabiankou commented on pull request #142:
URL: https://github.com/apache/maven-resolver/pull/142#issuecomment-1002586928


   > Does this intersect with 
https://issues.apache.org/jira/browse/MRESOLVER-133?
   
   @michael-o Only about the switching to BFS strategy, however it’s not the 
biggest part of the change. In fact the DFS > BFS change is irrelevant for that 
ticket as far as I can tell. The goal there is to change which version out of 
the version range is selected.
   
   **Now**
   1. Descriptors of all versions in all ranges resolved and added to the 
dependency graph.
   2. Dependency graph is transformed to resolve version conflicts (among other 
things).
   
   **Implied**
   1. Use the first newest resolvable descriptor; _(it makes sense to me, in 
fact this is almost [how the version of the root dependency is 
resolved](https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L187)
 except it does not proceed to older versions if newest can't be resolved)._
   2. Dependency graph is transformed to resolve version conflicts (among other 
things); _(still relevant since in other parts of the graph different version 
[range] might be used)_
   
   I'd say the ticket title and description is a bit misleading, but the 
improvement itself does make sense to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to