ibabiankou commented on pull request #142: URL: https://github.com/apache/maven-resolver/pull/142#issuecomment-1002661398
@michael-o They are quite independent indeed. They all related to the same area in the code, so even if considered and implemented separately I doubt it will be possible to revert them individually. >* Move from DFS to BFS which is a logical change and maybe may lead a difference dependency tree Are you talking here about the entire https://issues.apache.org/jira/browse/MRESOLVER-133 (DFS > BFS and changes to the version selection logic) or DFS to BFS change only? I believe it would be easier to consider them separately as version selection order can be changed separately. I can see how version selection change might result to a different dependency tree, however DFS > BFS alone should not have any impact, right? 🤔 >* Skip already visitited artifacts which is a logical change; expected not to change the dependency tree >* Download POM artifacts in parallel which is a purely technical improvement and does not affect dependency tree resolution at all Agree. I'll try to help with discussions and review, because I've already spent some time on this and would love to see these three changes to be implemented and released sooner rather than later 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
