Tibor17 commented on a change in pull request #419: URL: https://github.com/apache/maven-surefire/pull/419#discussion_r777135263
########## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ReportsMerger.java ########## @@ -0,0 +1,36 @@ +package org.apache.maven.plugin.surefire.report; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.apache.maven.surefire.api.suite.RunResult; + +import java.io.File; +import java.util.Collection; + +/** + * This interface is used to merge reports in {@link org.apache.maven.plugin.surefire.booterclient.ForkStarter}. + */ +public interface ReportsMerger +{ + void runStarting(); + void mergeFromOtherFactories( Collection<DefaultReporterFactory> factories ); + File getReportsDirectory(); + RunResult close(); Review comment: The close method is closing the status, no matter that the class name is factory, it really does closing the reports after JVM exit. But I do not want to spend time on talking about theory with design patterns. I was aiming for not giving the developer a chance to call the method I am reimplementing since this class is polymorphic - it has two usages in ForkStarter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
