Tibor17 commented on pull request #419: URL: https://github.com/apache/maven-surefire/pull/419#issuecomment-1019367621
@slawekjaranowski The feeling about the methods in the interface `ReportsMerger` would mean a refactoring and it is not my goal to make. If you see the usages of `DefaultReporterFactory` in `ForkStarter` you would notice that `DefaultReporterFactory` has three purposes, one is an aggregator of listeners which is `ReportsMerger`, second is Fork Reporter and the third purpose is a factory which is constructed in `ForkStarter` and passed into `ForkClient`. Of course it is possible to make a refactoring and rename few methods, which is your main whish coming from your feeling, but it is not the goal of this ticket. The fact is that the field `listeners` have to be shared and the private method `mergeTestHistoryResult()` must become protected and therefore the abstraction would contain an abstract class, three interfaces and implementation classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
