michael-o commented on a change in pull request #6:
URL: https://github.com/apache/maven-verifier/pull/6#discussion_r778695393
##########
File path: src/main/java/org/apache/maven/it/Embedded3xLauncher.java
##########
@@ -268,4 +271,26 @@ public String getMavenVersion()
throw new LauncherException( "Could not determine embedded Maven
version" );
}
+ /**
+ * Replicates the logic from <a href="https://git.io/JSMug";>Maven start
script</a> to find
+ * the project's base directory.
+ * @param workingDirectory the working directory
+ * @return the project's base directory
+ */
+ private static File findProjectBaseDirectory( File workingDirectory )
Review comment:
Attention, this could be confused with `${project.basedir}` which is not
the same. In the open JIRA ticket for a new property I have proposed something
like `project.executionRoot.basedir`. Would it make sense to use this term here
as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
