kwin commented on a change in pull request #6:
URL: https://github.com/apache/maven-verifier/pull/6#discussion_r778697909
##########
File path: src/main/java/org/apache/maven/it/Embedded3xLauncher.java
##########
@@ -268,4 +271,26 @@ public String getMavenVersion()
throw new LauncherException( "Could not determine embedded Maven
version" );
}
+ /**
+ * Replicates the logic from <a href="https://git.io/JSMug";>Maven start
script</a> to find
+ * the project's base directory.
+ * @param workingDirectory the working directory
+ * @return the project's base directory
+ */
+ private static File findProjectBaseDirectory( File workingDirectory )
Review comment:
Well, this is not necessarily the execution root, because the directory
usually stays the same no matter whether you really execute it on the project
root or just for a sub module (in case a .mvn directory is found). Also this is
how the init script calls it, therefore I would prefer keeping this name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
