Tibor17 commented on a change in pull request #470: URL: https://github.com/apache/maven-surefire/pull/470#discussion_r805856864
########## File path: surefire-report-parser/pom.xml ########## @@ -18,69 +18,70 @@ ~ under the License. --> -<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> - <modelVersion>4.0.0</modelVersion> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> - <parent> - <groupId>org.apache.maven.surefire</groupId> - <artifactId>surefire</artifactId> - <version>3.0.0-M6-SNAPSHOT</version> - </parent> + <parent> + <groupId>org.apache.maven.surefire</groupId> + <artifactId>surefire</artifactId> + <version>3.0.0-M6-SNAPSHOT</version> + </parent> Review comment: @slawekjaranowski But maven-shared-utils has CLI class, platform specific impl. We need it. Other classes are minor. If we could extract only that as sources and not bytecode, and if we substituted `DirectoryScanner ` with NIO Files, then yes, it would be possible to get right of shaded classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
