Tibor17 commented on a change in pull request #470: URL: https://github.com/apache/maven-surefire/pull/470#discussion_r805875737
########## File path: surefire-report-parser/pom.xml ########## @@ -18,69 +18,70 @@ ~ under the License. --> -<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> - <modelVersion>4.0.0</modelVersion> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> - <parent> - <groupId>org.apache.maven.surefire</groupId> - <artifactId>surefire</artifactId> - <version>3.0.0-M6-SNAPSHOT</version> - </parent> + <parent> + <groupId>org.apache.maven.surefire</groupId> + <artifactId>surefire</artifactId> + <version>3.0.0-M6-SNAPSHOT</version> + </parent> Review comment: @slawekjaranowski We shade the `maven-shared-utils` into `surefire-shared-utils`, and much more. I can imaging the dependency `maven-shared-utils` with type `sources` extracting CLI to generated sources, and adding new `DirectoryScanner` based on NIO in `src/main/java`. This can be done but you need to have a spare time to write unit tests for the scaner and several trivial utility methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
