Tibor17 commented on PR #523: URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1104439793
@mthmulders > > @mthmulders I have one more question. The developers would not be able to see the TAB because it is a white space. If the new guy would refactor it again, then this IT would not cover the purpose that it has now. I know it is a question of how the xml parser interprets the escaping characters in Maven but I would like to ask you for testing with escaping characters `	` on Maven 3.2.x and 3.8.x. WDYT? > > That's why I added XML comments saying those lines must be tab-indented. I've just tested locally: an XML file with `	` also breaks before the change in `DefaultForkConfiguration` (tested with Maven 4 SNAPSHOT, Maven 3.8.5 and Maven 3.2.5). So it seems to work equally fine for the test. Just tell me which one you prefer @Tibor17: tab characters, XML entities, or both. As you said, the TAB as a white space works equaly with `<argLine>-Dfoo.property="foo foo/foo/bar/1.0" 	 -Dbar.property="bar bar/foo/bar/2.0"</argLine>`. AFAIK the developers they press CTRL+ALT+L in IntelliJ IDEA, sometimes they are blind to see all the comments and therefore nothing stops them to refactor the the source code. If they do it, then the character `	` would stay forever, so it would be the strongest guarantee that the purpose is still there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
