dsubelman commented on PR #523:
URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1104543928

   > > > @dsubelman `argLine.replaceAll("\\s+", " ");` is nice. The code we 
have now still cannot trust the values which have a new line in system 
properties, e.g. `-DmyProp=my \n prop` but we cannot do anyting about it 
because we do not have smart mechanism to understand the structure of 
`argLine`. Till now nobody had any objections. The solution that we have is a 
kind of "too technical" but maybe this would stay untill the people would shout 
too much.
   > > 
   > > 
   > > When you say '_maybe this would stay until the people would shout too 
much_', do you mean to merge this pull request or not?
   > 
   > yes, of course, I would be glad to do that. I only want to open a 
discussion and tell you what I am thinking about and I want your opinions to be 
heard.
   
   Understood, thanks for the clarification. 
   
   Why would you use `\n` in system properties? In those cases, if you replace 
the `\n` with whitespace, change the behavior? In other words, you may need not 
remove `\n` in those cases?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to