cstamas commented on code in PR #38:
URL: https://github.com/apache/maven-filtering/pull/38#discussion_r893322895


##########
src/main/java/org/apache/maven/shared/filtering/DefaultMavenFileFilter.java:
##########
@@ -105,8 +110,6 @@ public void copyFile( File from, File to, boolean 
filtering, List<FileUtils.Filt
                 }
                 FileUtils.copyFile( from, to, encoding, new 
FileUtils.FilterWrapper[0], overwrite );
             }
-
-            buildContext.refresh( to );

Review Comment:
   You are missing the point: this parrot is dead. Very. Also, whatever it is, 
this was first attempt to implement incremental build, followed by two other 
attempts (by same person), that finally materialized in something completely 
different. So, yes, this may look "stable", the very same way dead parrot looks 
"stable" (well, not moving, is it?), but is superseded by several other 
attempts...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to