cstamas commented on code in PR #38:
URL: https://github.com/apache/maven-filtering/pull/38#discussion_r893340750
##########
src/main/java/org/apache/maven/shared/filtering/DefaultMavenFileFilter.java:
##########
@@ -105,8 +110,6 @@ public void copyFile( File from, File to, boolean
filtering, List<FileUtils.Filt
}
FileUtils.copyFile( from, to, encoding, new
FileUtils.FilterWrapper[0], overwrite );
}
-
- buildContext.refresh( to );
Review Comment:
Frankly, this should be other way around, don't you agree? This dead parrot
(not authored by us, not used by anything other than m2e) does not buy anything
for Maven itself (just adds extra complexity and more dependencies), does not
buy anything for any other IDE out there either and finally does not buy
anything for end users either. There is one and only one "beneficiary" of this
code, if any.
In other words, if tomorrow some Big Team approaches us, wanting to put some
"custom code" into Maven Core or Plugins to make it work for them, what would
you say? And next day another team, and so on...
Anyway, we are trying to move forward, spring cleanup time (pending since a
lot years), and we do accept quality patches as well, so nothing is lost here
IMO by removing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
