[
https://issues.apache.org/jira/browse/MSHARED-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604705#comment-17604705
]
Bartlomiej commented on MSHARED-1142:
-------------------------------------
Hello,
I fix that locally:
{code:bash}
project shared/filtering/ branch MSHARED-1142
-m
src/main/java/org/apache/maven/shared/filtering/DefaultMavenFileFilter.java
project shared/invoker/ branch MSHARED-1142
-m src/main/java/org/apache/maven/shared/invoker/DefaultInvoker.java
-m
src/main/java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java
project shared/jarsigner/ branch MSHARED-1142
-m src/main/java/org/apache/maven/shared/jarsigner/DefaultJarSigner.java
project shared/shared-io/ branch MSHARED-1142
-m
src/main/java/org/apache/maven/shared/io/download/DefaultDownloadManager.java
project shared/verifier/ branch MSHARED-1142
-m src/main/java/org/apache/maven/shared/verifier/Embedded3xLauncher.java
-m src/main/java/org/apache/maven/shared/verifier/Verifier.java
{code}
How to PR then?
> Remove e.getMessage() duplication when e is passed as object
> ------------------------------------------------------------
>
> Key: MSHARED-1142
> URL: https://issues.apache.org/jira/browse/MSHARED-1142
> Project: Maven Shared Components
> Issue Type: Task
> Components: maven-verifier
> Reporter: Michael Osipov
> Priority: Major
> Labels: up-for-grabs
> Fix For: maven-verifier-2.0.0
>
>
> In many spots this is code:
> {noformat}
> throw new Exception( "Failed to run Maven: " + e.getMessage(), e ); {noformat}
> {{e.getMessage()}} is redundant because {{e}} is already passed to the new
> exception. It will duplicate the message. Zero benefit. We shall remove them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
