[ 
https://issues.apache.org/jira/browse/MSHARED-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604719#comment-17604719
 ] 

Michael Osipov commented on MSHARED-1142:
-----------------------------------------

[~sjaranowski] , what a coincidence we are currently discussing. As also 
mentioned on the Maven Site PR, if someone cannot/doesn't want to use GH, I 
won't force and a patch is just fine.

> Remove e.getMessage() duplication when e is passed as object
> ------------------------------------------------------------
>
>                 Key: MSHARED-1142
>                 URL: https://issues.apache.org/jira/browse/MSHARED-1142
>             Project: Maven Shared Components
>          Issue Type: Task
>          Components: maven-verifier
>            Reporter: Michael Osipov
>            Priority: Major
>              Labels: up-for-grabs
>             Fix For: maven-verifier-2.0.0
>
>
> In many spots this is code:
> {noformat}
> throw new Exception( "Failed to run Maven: " + e.getMessage(), e ); {noformat}
> {{e.getMessage()}} is redundant because {{e}} is already passed to the new 
> exception. It will duplicate the message. Zero benefit. We shall remove them.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to