[
https://issues.apache.org/jira/browse/MRESOLVER-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609048#comment-17609048
]
ASF GitHub Bot commented on MRESOLVER-266:
------------------------------------------
michael-o commented on code in PR #196:
URL: https://github.com/apache/maven-resolver/pull/196#discussion_r979313840
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/DefaultSyncContextFactory.java:
##########
@@ -130,18 +130,18 @@ public SyncContext newInstance( final
RepositorySystemSession session, final boo
private NamedLockFactoryAdapter createAdapter( final
RepositorySystemSession session )
{
- String nameMapperName = ConfigUtils.getString( session,
DEFAULT_NAME_MAPPER, NAME_MAPPER_KEY );
- String namedLockFactoryName = ConfigUtils.getString( session,
DEFAULT_FACTORY, FACTORY_KEY );
+ String nameMapperName = ConfigUtils.getString( session,
DEFAULT_NAME_MAPPER_NAME, NAME_MAPPER_KEY );
+ String namedLockFactoryName = ConfigUtils.getString( session,
DEFAULT_FACTORY_NAME, FACTORY_KEY );
NameMapper nameMapper = nameMappers.get( nameMapperName );
if ( nameMapper == null )
{
- throw new IllegalArgumentException( "Unknown NameMapper name: " +
namedLockFactoryName
+ throw new IllegalArgumentException( "Unknown nameMapperName: " +
namedLockFactoryName
+ ", known ones: " + nameMappers.keySet() );
}
NamedLockFactory namedLockFactory = namedLockFactories.get(
namedLockFactoryName );
if ( namedLockFactory == null )
{
- throw new IllegalArgumentException( "Unknown NamedLockFactory
name: " + namedLockFactoryName
+ throw new IllegalArgumentException( "Unknown namedLockFactory: " +
namedLockFactoryName
Review Comment:
Isn't this now inconsistent with the `NameMapper`? The term `name` is now
gone.
> Simplify adapter creation and align configuration for it
> --------------------------------------------------------
>
> Key: MRESOLVER-266
> URL: https://issues.apache.org/jira/browse/MRESOLVER-266
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
> Reporter: Tamás Cservenák
> Assignee: Tamás Cservenák
> Priority: Major
> Fix For: resolver-next
>
>
> Rework how named lock factory adapter is created, it is the ONLY bit reaching
> directly to Java System Properties instead to rely on session config
> properties. This makes it impossible to control from Maven for example (as it
> is "too late").
> Proposed changes:
> * adapter should be created based on session config properties, not Java
> system properties
> * adapter should be stored within session
> * adapter creation should be vastly simplified (currently we have 4 involved
> class: selectors and default sync context)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
