[
https://issues.apache.org/jira/browse/MRESOLVER-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609047#comment-17609047
]
ASF GitHub Bot commented on MRESOLVER-266:
------------------------------------------
michael-o commented on code in PR #196:
URL: https://github.com/apache/maven-resolver/pull/196#discussion_r979313794
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/DefaultSyncContextFactory.java:
##########
@@ -161,7 +161,7 @@ public void shutdown()
}
catch ( Exception e )
{
- LOGGER.warn( "Could not shutdown adapter", e );
+ LOGGER.warn( "Could not shutdown: " + adapter, e );
Review Comment:
`"Could not shutdown: {}", e`
> Simplify adapter creation and align configuration for it
> --------------------------------------------------------
>
> Key: MRESOLVER-266
> URL: https://issues.apache.org/jira/browse/MRESOLVER-266
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
> Reporter: Tamás Cservenák
> Assignee: Tamás Cservenák
> Priority: Major
> Fix For: resolver-next
>
>
> Rework how named lock factory adapter is created, it is the ONLY bit reaching
> directly to Java System Properties instead to rely on session config
> properties. This makes it impossible to control from Maven for example (as it
> is "too late").
> Proposed changes:
> * adapter should be created based on session config properties, not Java
> system properties
> * adapter should be stored within session
> * adapter creation should be vastly simplified (currently we have 4 involved
> class: selectors and default sync context)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
