cstamas commented on code in PR #178:
URL: https://github.com/apache/maven-resolver/pull/178#discussion_r983453759
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/bf/BfDependencyCollector.java:
##########
@@ -365,6 +477,64 @@ else if ( descriptorResult == DataPool.NO_DESCRIPTOR )
return descriptorResult;
}
+ static class ParallelDescriptorResolver
+ {
+ final ExecutorService executorService;
Review Comment:
Own executor is just fine, we should not raise complexity.... but, as I see
executor is created per invocation, and this may be problematic (parallel
build?), so instead, why not cache it during lifespan of session? That would
make one executor being created and shared as long as session exists, no?
But then question comes, when to shut it down? Like, the shutdown method
could perform some "ref counting"? And the last leaving the building turn off
lights?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
