cstamas commented on code in PR #178:
URL: https://github.com/apache/maven-resolver/pull/178#discussion_r983504722
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/bf/BfDependencyCollector.java:
##########
@@ -365,6 +477,64 @@ else if ( descriptorResult == DataPool.NO_DESCRIPTOR )
return descriptorResult;
}
+ static class ParallelDescriptorResolver
+ {
+ final ExecutorService executorService;
Review Comment:
the executor exists in connector, this is impl module, connector does not
depend on impl nor impl depend on connector, see
https://maven.apache.org/resolver/index.html
Now, not only that, but also it is quite possible that execution does not
"even get to" connector (ie. all is present locally), so this would require
major undertake, probably to move executor providing component to SPI (as util
is not quite the place for this), then change both uses (so BF collector and
connector), but in connector module we'd need to provide some "stub"
implementation (as again, it does not depend on impl), and finally that would
become one whole. But even writing this down is long, and seems totally
unrelated to this PR.
Am currently totally not concerned about sharing executor, but more that
executor is created per invocation of collect merhd...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
