[
https://issues.apache.org/jira/browse/MNG-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613899#comment-17613899
]
ASF GitHub Bot commented on MNG-7556:
-------------------------------------
michael-o commented on code in PR #810:
URL: https://github.com/apache/maven/pull/810#discussion_r989731168
##########
maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java:
##########
@@ -338,9 +338,9 @@ public void testMVNConfigurationFunkyArguments()
String revision = System.getProperty( "revision" );
assertEquals( "8.2.0", revision );
- assertEquals( "bar ", request.getSystemProperties().getProperty( "foo"
) );
- assertEquals( "bar two", request.getSystemProperties().getProperty(
"foo2" ) );
- assertEquals( "Apache Maven",
request.getSystemProperties().getProperty( "label" ) );
+ assertEquals( "bar ", request.getUserProperties().getProperty( "foo" )
);
+ assertEquals( "bar two", request.getUserProperties().getProperty(
"foo2" ) );
+ assertEquals( "Apache Maven", request.getUserProperties().getProperty(
"label" ) );
Review Comment:
Yes, correct. This explicitly not subject of this PR. This statement should
go away sometime in the future.
> Clean up notion between user properties and system properties
> -------------------------------------------------------------
>
> Key: MNG-7556
> URL: https://issues.apache.org/jira/browse/MNG-7556
> Project: Maven
> Issue Type: Task
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.9.0-candidate, 4.0.0-alpha-1, 4.0.0
>
>
> For a very long time we have documented that the user can set system
> properties via {{mvn -Dfoo=bar}}, but actually those are user properties
> which are promoted to system properties and it some cases system properties
> cannot be modified *after* the JVM has been started. To properly set system
> properties there are basically two ways:
> * use {{MAVEN_OPTS}} environment variable
> * use {{.mvn/jvm.config}} file
> A third option in the future we could introduce, like other Java tools, a
> {{-J-Dfoo=bar}} option with the restriction of the the paragraph above.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
