[
https://issues.apache.org/jira/browse/MNG-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613966#comment-17613966
]
ASF GitHub Bot commented on MNG-7556:
-------------------------------------
michael-o commented on code in PR #810:
URL: https://github.com/apache/maven/pull/810#discussion_r989848619
##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -150,6 +150,7 @@ public DefaultRepositorySystemSession newRepositorySession(
MavenExecutionReques
configProps.put( ConfigurationProperties.USER_AGENT, getUserAgent() );
configProps.put( ConfigurationProperties.INTERACTIVE,
request.isInteractiveMode() );
configProps.put( "maven.startTime", request.getStartTime() );
+ // TODO Why is this duplication necessary?
Review Comment:
Added comment.
##########
maven-core/src/main/java/org/apache/maven/project/artifact/MavenMetadataSource.java:
##########
@@ -569,6 +569,7 @@ private ProjectRelocation retrieveRelocatedProject(
Artifact artifact, MetadataR
configuration.setValidationLevel(
ModelBuildingRequest.VALIDATION_LEVEL_MINIMAL );
configuration.setProcessPlugins( false );
configuration.setRepositoryMerging(
ProjectBuildingRequest.RepositoryMerging.REQUEST_DOMINANT );
+ // TODO How to access here Maven's copy of system
properties and user properties?
Review Comment:
Updated spot, thanks!
> Clean up notion between user properties and system properties
> -------------------------------------------------------------
>
> Key: MNG-7556
> URL: https://issues.apache.org/jira/browse/MNG-7556
> Project: Maven
> Issue Type: Task
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.9.0-candidate, 4.0.0-alpha-1, 4.0.0
>
>
> For a very long time we have documented that the user can set system
> properties via {{mvn -Dfoo=bar}}, but actually those are user properties
> which are promoted to system properties and it some cases system properties
> cannot be modified *after* the JVM has been started. To properly set system
> properties there are basically two ways:
> * use {{MAVEN_OPTS}} environment variable
> * use {{.mvn/jvm.config}} file
> A third option in the future we could introduce, like other Java tools, a
> {{-J-Dfoo=bar}} option with the restriction of the the paragraph above.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
