[
https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622155#comment-17622155
]
ASF GitHub Bot commented on MNG-6609:
-------------------------------------
gnodet commented on code in PR #835:
URL: https://github.com/apache/maven/pull/835#discussion_r1001591928
##########
maven-model-builder/src/main/java/org/apache/maven/model/profile/ProfileActivationContext.java:
##########
@@ -30,6 +30,12 @@
*/
public interface ProfileActivationContext
{
+ /**
+ * Key of the property containing the project's packaging.
+ * Available in {@link #getUserProperties()}.
+ * @since 4.0
+ */
+ String PROPERTY_NAME_PACKAGING = "project.packaging";
Review Comment:
Shouldn't that be `packaging` to align with
https://github.com/apache/maven/blob/2a9f39336cec1d8e52d30cc48503d51ed8672536/maven-model-builder/src/main/java/org/apache/maven/model/path/ProfileActivationFilePathInterpolator.java#L75-L82
I think the same reasoning apply, we don't support all `project.*`
properties...
> Profile activation by packaging
> --------------------------------
>
> Key: MNG-6609
> URL: https://issues.apache.org/jira/browse/MNG-6609
> Project: Maven
> Issue Type: Improvement
> Components: Profiles
> Affects Versions: 3.6.0
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> Due to the lack of mixins, it is common that modules which use different
> packagings share the same parent pom. As those often use different
> dependencies/plugins, it would be nice to have profiles which are activated
> based on the packaging of a module. That is currently not possible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
