bmarwell commented on code in PR #82:
URL: https://github.com/apache/maven-parent/pull/82#discussion_r1002660686
##########
pom.xml:
##########
@@ -294,20 +292,20 @@ under the License.
<id>adangel</id>
<name>Andreas Dangel</name>
<email>[email protected]</email>
- <timezone>Europe/Berlin</timezone>
<roles>
<role>Committer</role>
</roles>
+ <timezone>Europe/Berlin</timezone>
</developer>
<developer>
<id>bdemers</id>
<name>Brian Demers</name>
- <organization>Sonatype</organization>
<email>[email protected]</email>
- <timezone>-5</timezone>
+ <organization>Sonatype</organization>
Review Comment:
That's outdated. You might want to update or remove it while at it. He's now
working for Okta.
##########
pom.xml:
##########
@@ -1170,19 +1175,63 @@ under the License.
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>com.diffplug.spotless</groupId>
+ <artifactId>spotless-maven-plugin</artifactId>
+ <version>2.27.1</version>
+ <configuration>
+ <java>
+ <importOrder>
+ <file>config/maven-eclipse-importorder.txt</file>
+ </importOrder>
+ <removeUnusedImports/>
+ <palantirJavaFormat/>
+ <licenseHeader>
+ <file>config/maven-header-plain.txt</file>
+ </licenseHeader>
+ </java>
+ <pom>
+ <sortPom>
+ <expandEmptyElements>false</expandEmptyElements>
Review Comment:
Expanding empty elements would allow less diff noise.
##########
pom.xml:
##########
@@ -104,10 +102,10 @@ under the License.
<id>cstamas</id>
<name>Tamas Cservenak</name>
<email>[email protected]</email>
- <timezone>+1</timezone>
<roles>
<role>PMC Member</role>
</roles>
+ <timezone>+1</timezone>
Review Comment:
This should be a timezone name, while at it. But works for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
