gnodet commented on PR #82: URL: https://github.com/apache/maven-parent/pull/82#issuecomment-1288069866
> > > LGTM but if we move to spotless. I would remove `checkstyle:check` as well as we do not need really to check sources style twice during the build.... > > > And it's a bit confusing as when testing this pom with m-war-p, `checkstyle:check` is passing but not `spotless:check' > > > > > > @olamy Checkstyle checks method length, file length, qualifier order, parameter numbers, field/method ordering, etc... Those won't be checked by pure code style validation. I don't really see the value for removing those checks. > > ah right sorry. but still everything concerning style in checkstyle (sorry but the name is confusing ;) ) can be removed. I mean such https://github.com/apache/maven-shared-resources/blob/f9f3527cd3546e208f5d13e1ca37ba763bac6d0c/src/main/resources/config/maven_checks.xml#L61 > > nothing really urgent as long as it's in sync. Yes, the problem is that I was fearing a bit removing those checks from `maven-shared-resources`. If a projet upgrades this dependency but does not use the latest parent, it will have some checks not enforced anymore. But yes, at some point, it should be synced. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
