[
https://issues.apache.org/jira/browse/MPLUGIN-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625508#comment-17625508
]
ASF GitHub Bot commented on MPLUGIN-437:
----------------------------------------
gnodet commented on code in PR #167:
URL:
https://github.com/apache/maven-plugin-tools/pull/167#discussion_r1007785543
##########
maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/converter/JavaClassConverterContext.java:
##########
@@ -81,13 +80,6 @@ public JavaClassConverterContext( JavaClass mojoClass,
JavaClass declaringClass,
Map<String, MojoAnnotatedClass>
mojoAnnotatedClasses,
JavadocLinkGenerator linkGenerator, int
lineNumber )
{
- if ( !( mojoClass.getJavaClassLibrary() instanceof SourceLibrary )
Review Comment:
I did remove the fact that the generation will throw an exception, not the
fact that it will be used. Resolving javadoc reference is an order less
important than having the plugin generate the descriptor. In my use case, it
was throwing an exception and failed the whole build.
> Plugin generator generation fails when the parent class comes from a
> different project
> --------------------------------------------------------------------------------------
>
> Key: MPLUGIN-437
> URL: https://issues.apache.org/jira/browse/MPLUGIN-437
> Project: Maven Plugin Tools
> Issue Type: Task
> Affects Versions: 3.7.0
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Priority: Major
> Fix For: 3.7.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
