[
https://issues.apache.org/jira/browse/MPLUGIN-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625605#comment-17625605
]
ASF GitHub Bot commented on MPLUGIN-437:
----------------------------------------
gnodet commented on code in PR #167:
URL:
https://github.com/apache/maven-plugin-tools/pull/167#discussion_r1007937706
##########
maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/converter/JavaClassConverterContext.java:
##########
@@ -81,13 +80,6 @@ public JavaClassConverterContext( JavaClass mojoClass,
JavaClass declaringClass,
Map<String, MojoAnnotatedClass>
mojoAnnotatedClasses,
JavadocLinkGenerator linkGenerator, int
lineNumber )
{
- if ( !( mojoClass.getJavaClassLibrary() instanceof SourceLibrary )
Review Comment:
> Also how can meta information from the parent mojos be extracted which are
not part of the binary (i.e. coming from javadoc like description, since or
deprecated)? I think this requires evaluation of the parent's plugin
descriptor....
I guess they don't.
Instead of warning upfront, I think it would be better to display a warning
at the time the information can not be retrieved. That would avoid irrelevant
warnings to be displayed. For example if the parent class does not contain any
parameter definition, a warning would be irrelevant noise.
> Plugin generator generation fails when the parent class comes from a
> different project
> --------------------------------------------------------------------------------------
>
> Key: MPLUGIN-437
> URL: https://issues.apache.org/jira/browse/MPLUGIN-437
> Project: Maven Plugin Tools
> Issue Type: Task
> Affects Versions: 3.7.0
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Priority: Major
> Fix For: 3.7.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
