[
https://issues.apache.org/jira/browse/MRESOLVER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628174#comment-17628174
]
ASF GitHub Bot commented on MRESOLVER-283:
------------------------------------------
cstamas commented on code in PR #213:
URL: https://github.com/apache/maven-resolver/pull/213#discussion_r1012586206
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/bf/BfDependencyCollector.java:
##########
@@ -475,23 +482,22 @@ else if ( descriptorResult == DataPool.NO_DESCRIPTOR )
static class ParallelDescriptorResolver
{
- final ExecutorService executorService;
+ final ResolverExecutor executor;
/**
* Artifact ID -> Future of DescriptorResolutionResult
*/
final Map<String, Future<DescriptorResolutionResult>> results = new
ConcurrentHashMap<>( 256 );
- final Logger logger = LoggerFactory.getLogger( getClass() );
- ParallelDescriptorResolver( RepositorySystemSession session )
+ ParallelDescriptorResolver( ResolverExecutor executor )
{
- this.executorService = getExecutorService( session );
+ this.executor = executor;
}
void resolveDescriptors( Artifact artifact,
Callable<DescriptorResolutionResult> callable )
{
results.computeIfAbsent( ArtifactIdUtils.toId( artifact ),
- key -> this.executorService.submit( callable ) );
+ key -> this.executor.submit( callable ) );
Review Comment:
Hopefully I restored the original behaviour, please recheck (latest commit)
> Introduce resolver wide "shared" executor service
> -------------------------------------------------
>
> Key: MRESOLVER-283
> URL: https://issues.apache.org/jira/browse/MRESOLVER-283
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 1.9.0
>
>
> More and more component in resolver does parallel processing (BF collector,
> MD resolver, basic connector), and they all create, maintain their own
> executor instance.
> Instead of this, create one shared "thread pool" (executor) component and
> just share it accross resovler.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
