[
https://issues.apache.org/jira/browse/MRESOLVER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629715#comment-17629715
]
ASF GitHub Bot commented on MRESOLVER-283:
------------------------------------------
cstamas commented on code in PR #213:
URL: https://github.com/apache/maven-resolver/pull/213#discussion_r1015198275
##########
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##########
@@ -146,8 +150,10 @@
this.repository = repository;
this.fileProcessor = fileProcessor;
this.providedChecksumsSources = providedChecksumsSources;
+ this.resolverExecutor = resolverExecutorService.getResolverExecutor(
session, RepositoryConnector.class,
+ ConfigUtils.getInteger( session, CONFIG_PROP_THREADS_DEFAULT,
CONFIG_PROP_THREADS,
+ "maven.artifact.threads" ) );
Review Comment:
Maybe we should just remove it? We are going for 1.9 after all....
> Introduce resolver wide "shared" executor service
> -------------------------------------------------
>
> Key: MRESOLVER-283
> URL: https://issues.apache.org/jira/browse/MRESOLVER-283
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 1.9.0
>
>
> More and more component in resolver does parallel processing (BF collector,
> MD resolver, basic connector), and they all create, maintain their own
> executor instance.
> Instead of this, create one shared service component and just reuse it
> accross resolver.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)