[
https://issues.apache.org/jira/browse/MBUILDCACHE-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629146#comment-17629146
]
ASF GitHub Bot commented on MBUILDCACHE-34:
-------------------------------------------
AlexanderAshitkin commented on code in PR #36:
URL:
https://github.com/apache/maven-build-cache-extension/pull/36#discussion_r1014328462
##########
src/test/java/org/apache/maven/buildcache/its/junit/IntegrationTestExtension.java:
##########
@@ -208,6 +208,8 @@ public Object resolveParameter( ParameterContext
parameterContext,
Verifier verifier = new Verifier( testExecutionDir.toString(),
true );
verifier.setLogFileName( "../log.txt" );
+ verifier.setSystemProperty( "projectVersion", System.getProperty(
"projectVersion" ) );
+ verifier.setLocalRepo( System.getProperty( "localRepo" ) );
Review Comment:
Please notice I also faced a similar problem [while adding
tests](https://github.com/apache/maven-build-cache-extension/pull/36/src/test/java/org/apache/maven/buildcache/its/ForkedExecutionsTest.java).
But I decided to use per-run temp directory to have clean state between runs
(at least for cache).
So here are the questions:
- how this repository is cleaned?
- Will it be unique between tests? Each integration test assumes clean state
- On local workstation - will it be also clean each time? Tests to be run on
local machine as well
> Improve IT test execution
> -------------------------
>
> Key: MBUILDCACHE-34
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-34
> Project: Maven Build Cache Extension
> Issue Type: Improvement
> Reporter: Slawomir Jaranowski
> Assignee: Slawomir Jaranowski
> Priority: Major
> Labels: pull-request-available
>
> * IT tests should use separate local repository
> * version of tested component should be parameterized
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
