[
https://issues.apache.org/jira/browse/MBUILDCACHE-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629173#comment-17629173
]
ASF GitHub Bot commented on MBUILDCACHE-34:
-------------------------------------------
slawekjaranowski commented on code in PR #36:
URL:
https://github.com/apache/maven-build-cache-extension/pull/36#discussion_r1014397365
##########
src/test/java/org/apache/maven/buildcache/its/junit/IntegrationTestExtension.java:
##########
@@ -208,6 +208,8 @@ public Object resolveParameter( ParameterContext
parameterContext,
Verifier verifier = new Verifier( testExecutionDir.toString(),
true );
verifier.setLogFileName( "../log.txt" );
+ verifier.setSystemProperty( "projectVersion", System.getProperty(
"projectVersion" ) );
+ verifier.setLocalRepo( System.getProperty( "localRepo" ) );
Review Comment:
- `localRepo` is used to set property `maven.repo.local` which point to
local Maven repository, instead of standard `.m2/repository`
- `localRepo` value is passed from pom.xml
```
<localRepo>${project.build.directory}/local-repo</localRepo>
```
so it is in `target` directory, it will be cleaned in standard way
`localRepo` is first populated by m-invoker-p by install goal before
integration test will be started, and current project arifact is instaled, next
Maven process which is executed during test, download everything else was is
needed
before my change is m-install-p was configured to install project artifact
in standard Maven local repository
it is shared by all test
on local workstation it will be the same
https://maven.apache.org/plugins/maven-invoker-plugin/install-mojo.html
> Improve IT test execution
> -------------------------
>
> Key: MBUILDCACHE-34
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-34
> Project: Maven Build Cache Extension
> Issue Type: Improvement
> Reporter: Slawomir Jaranowski
> Assignee: Slawomir Jaranowski
> Priority: Major
> Labels: pull-request-available
>
> * IT tests should use separate local repository
> * version of tested component should be parameterized
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
