[
https://issues.apache.org/jira/browse/MRESOLVER-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629156#comment-17629156
]
ASF GitHub Bot commented on MRESOLVER-282:
------------------------------------------
michael-o commented on code in PR #212:
URL: https://github.com/apache/maven-resolver/pull/212#discussion_r1014349535
##########
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##########
@@ -524,11 +492,6 @@ protected void runTask()
checksumValidator.commit();
}
}
- finally
- {
- partFile.close();
- checksumValidator.close();
Review Comment:
Why is the second close not necessary anymore?
> Drop PartialFile
> ----------------
>
> Key: MRESOLVER-282
> URL: https://issues.apache.org/jira/browse/MRESOLVER-282
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 1.9.0
>
>
> Drop {{PartialFile}} that may cause locking issues, the drawback is to loose
> "resumable downloads".
> Also, clear up the temp file usage around it, and simplify resource handling.
> After this change, resolver will download "all or nothing", no more partial
> downloads (hence, nothing to resume). HttpClientTransport is STILL ABLE to
> resolve, but resolver is currently not using this feature, later we may
> reintroduce it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
