[
https://issues.apache.org/jira/browse/MRESOLVER-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630276#comment-17630276
]
ASF GitHub Bot commented on MRESOLVER-282:
------------------------------------------
cstamas commented on PR #212:
URL: https://github.com/apache/maven-resolver/pull/212#issuecomment-1306836468
> Looks good. Any particular reason to remove the resume feature ? Does it
cause known problems or is that just a code clean up ?
Both: is cleanup of ancient code, but also causes issues as devs reported
(IDE + Maven got stuck in infinite loop due file lock), and after all, this
code predates SyncContext that handles file locking now instead. Am unsure how
much "resume download" was actually used, given it was ONLY http transport
capable of (Wagon is 99% used by users and it is NOT capable of resuming).
> Drop PartialFile
> ----------------
>
> Key: MRESOLVER-282
> URL: https://issues.apache.org/jira/browse/MRESOLVER-282
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 1.9.0
>
>
> Drop {{PartialFile}} that may cause locking issues, the drawback is to loose
> "resumable downloads".
> Also, clear up the temp file usage around it, and simplify resource handling.
> After this change, resolver will download "all or nothing", no more partial
> downloads (hence, nothing to resume). HttpClientTransport is STILL ABLE to
> resolve, but resolver is currently not using this feature, later we may
> reintroduce it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
