[
https://issues.apache.org/jira/browse/MRESOLVER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629719#comment-17629719
]
ASF GitHub Bot commented on MRESOLVER-283:
------------------------------------------
cstamas commented on code in PR #213:
URL: https://github.com/apache/maven-resolver/pull/213#discussion_r1015202072
##########
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##########
@@ -287,9 +269,10 @@ public void get( Collection<? extends ArtifactDownload>
artifactDownloads,
task = new GetTaskRunner( location, transfer.getFile(),
checksumPolicy,
checksumAlgorithmFactories, checksumLocations,
providedChecksums, listener );
}
- executor.execute( errorForwarder.wrap( task ) );
+ runnable.add( errorForwarder.wrap( task ) );
}
+ resolverExecutor.submitOrDirect( runnable );
Review Comment:
What is the difference? It's not this line that wait but next, the unchanged
one.
> Introduce resolver wide "shared" executor service
> -------------------------------------------------
>
> Key: MRESOLVER-283
> URL: https://issues.apache.org/jira/browse/MRESOLVER-283
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 1.9.0
>
>
> More and more component in resolver does parallel processing (BF collector,
> MD resolver, basic connector), and they all create, maintain their own
> executor instance.
> Instead of this, create one shared service component and just reuse it
> accross resolver.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
