[
https://issues.apache.org/jira/browse/MPLUGIN-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630812#comment-17630812
]
ASF GitHub Bot commented on MPLUGIN-425:
----------------------------------------
kwin commented on code in PR #171:
URL:
https://github.com/apache/maven-plugin-tools/pull/171#discussion_r1017532626
##########
maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/DefaultMojoAnnotationsScanner.java:
##########
@@ -85,12 +87,18 @@ public Map<String, MojoAnnotatedClass> scan(
MojoAnnotationsScannerRequest reque
for ( Artifact dependency : request.getDependencies() )
{
scan( mojoAnnotatedClasses, dependency.getFile(),
request.getIncludePatterns(), dependency, true );
+ if ( request.getMavenApiVersion() == null
+ && dependency.getFile().getName().contains(
"maven-plugin-api" ) )
+ {
+ request.setMavenApiVersion( getSpecificationVersionOfJar(
dependency.getFile() ) );
+ }
Review Comment:
Yes, a lot simpler, done in
https://github.com/apache/maven-plugin-tools/pull/171/commits/4c8e2499919b75c2e1cd5a12e474dc65070f7d4f.
> Plugin descriptor should optionally contain the
> requiredJavaVersion/requiredMavenVersion
> ----------------------------------------------------------------------------------------
>
> Key: MPLUGIN-425
> URL: https://issues.apache.org/jira/browse/MPLUGIN-425
> Project: Maven Plugin Tools
> Issue Type: Improvement
> Components: Plugin Plugin
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> As plugin descriptor schema v 1.1.0 supports requiring a Java version
> (support added in MNG-7566) and Maven version (support added in MNG-7570),
> the descriptor goal provide a dedicated mojo parameter to set these elements.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
