[
https://issues.apache.org/jira/browse/MPLUGIN-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630828#comment-17630828
]
ASF GitHub Bot commented on MPLUGIN-425:
----------------------------------------
slawekjaranowski commented on code in PR #171:
URL:
https://github.com/apache/maven-plugin-tools/pull/171#discussion_r1017556756
##########
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java:
##########
@@ -235,6 +238,42 @@
@Parameter( defaultValue = "${localRepository}", required = true, readonly
= true )
private ArtifactRepository local;
+ /**
+ * The required Java version to set in the plugin descriptor. This is
evaluated by Maven 4 and ignored by earlier
+ * Maven versions. Can be either one of the following formats:
+ *
+ * <ul>
+ * <li>One of the values as for <a
href="https://maven.apache.org/pom.html#Activation";>POM profile activation
+ * element {@code jdk}</a>, i.e. version ranges, version prefixes
+ * and negated version prefixes (starting with '!').</li>
+ * <li>{@code "auto"} to determine the minimum Java version from the
binary class version being generated during
+ * compilation (determined by the extractor).</li>
+ * </ul>
+ *
+ * @since 3.8.0
+ */
+ @Parameter( defaultValue = VALUE_AUTO )
+ String requiredJavaVersion;
+
+ /**
+ * The required Maven version to set in the plugin descriptor. This is
evaluated by Maven 4 and ignored by earlier
+ * Maven versions. Can be either one of the following formats:
+ *
+ * <ul>
+ * <li>A version range which specifies the supported Maven versions. It
can either use the usual mathematical
+ * syntax like {@code "[2.0.10,2.1.0),[3.0,)"} or use a single version
like {@code "2.2.1"}. The latter is a short
+ * form for {@code "[2.2.1,)"}, i.e. denotes the minimum version
required.</li>
+ * <li>{@code "auto"} to determine the minimum Maven version from the POMs
Maven prerequisite, or if not set the
+ * referenced Maven Plugin API version.</li>
+ * </ul>
+ * This value (if not set to {@code "none"}) takes precedence over the
Review Comment:
`none` is not present
> Plugin descriptor should optionally contain the
> requiredJavaVersion/requiredMavenVersion
> ----------------------------------------------------------------------------------------
>
> Key: MPLUGIN-425
> URL: https://issues.apache.org/jira/browse/MPLUGIN-425
> Project: Maven Plugin Tools
> Issue Type: Improvement
> Components: Plugin Plugin
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> As plugin descriptor schema v 1.1.0 supports requiring a Java version
> (support added in MNG-7566) and Maven version (support added in MNG-7570),
> the descriptor goal provide a dedicated mojo parameter to set these elements.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
