[
https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655456#comment-17655456
]
ASF GitHub Bot commented on MWRAPPER-88:
----------------------------------------
slawekjaranowski commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063447254
##########
.github/workflows/shellcheck-posix.yml:
##########
@@ -27,7 +27,7 @@ jobs:
runs-on: ubuntu-latest
env:
SHELLCHECK_VERSION: '0.9.0'
- SHELLCHECK_OPTS: '-e SC2009'
+ SHELLCHECK_OPTS: '-e SC1091 -e SC2009'
Review Comment:
I would like to add description what this numbers means - what rule is
exclude
##########
.github/workflows/shellcheck-posix.yml:
##########
@@ -39,7 +39,7 @@ jobs:
- name: check
run: |
echo "$GITHUB_WORKSPACE/shellcheck-v${SHELLCHECK_VERSION}" >>
$GITHUB_PATH
- readarray -t SCRIPT_FILES < <(grep -ErIl
'^#![[:blank:]]*/bin/(ba|da|c|k)?sh'
"$GITHUB_WORKSPACE/maven-wrapper-distribution/src/resources")
+ readarray -t SCRIPT_FILES < <(grep -ErIl -e
'^#![[:blank:]]*/bin/(ba|da|c|k)?sh' -e
'^#!/usr/bin/env[[:blank:]]+(ba|da|c|k)?sh'
"$GITHUB_WORKSPACE/maven-wrapper-distribution/src/resources")
Review Comment:
should it also match `zsh`?
> mvnw is not POSIX compatible
> ----------------------------
>
> Key: MWRAPPER-88
> URL: https://issues.apache.org/jira/browse/MWRAPPER-88
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
> Affects Versions: 3.1.1
> Reporter: Benjamin Marwell
> Assignee: Benjamin Marwell
> Priority: Major
> Labels: posix
>
> * POSIX scripts should not use bash-specific features
> * Fix suggestions from shellcheck
> ([https://github.com/apache/maven-wrapper/pull/74])
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
