[
https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655490#comment-17655490
]
ASF GitHub Bot commented on MWRAPPER-88:
----------------------------------------
gnodet commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063547852
##########
maven-wrapper-distribution/src/resources/mvnw:
##########
@@ -237,8 +243,7 @@ else
fi
if [ -e "$javaClass" ]; then
log " - Running MavenWrapperDownloader.java ..."
- ("$JAVA_HOME/bin/java" -cp .mvn/wrapper MavenWrapperDownloader
"$wrapperUrl" "$wrapperJarPath")
- [ $? -eq 0 ] || rm -f "$wrapperJarPath"
+ ("$JAVA_HOME/bin/java" -cp .mvn/wrapper MavenWrapperDownloader
"$wrapperUrl" "$wrapperJarPath") || rm -f "$wrapperJarPath"
Review Comment:
To be coherent, maybe we should rewrite it to the more simple:
```
"$JAVA_HOME/bin/java" -cp .mvn/wrapper MavenWrapperDownloader "$wrapperUrl"
"$wrapperJarPath"
```
> mvnw is not POSIX compatible
> ----------------------------
>
> Key: MWRAPPER-88
> URL: https://issues.apache.org/jira/browse/MWRAPPER-88
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
> Affects Versions: 3.1.1
> Reporter: Benjamin Marwell
> Assignee: Benjamin Marwell
> Priority: Major
> Labels: posix
>
> * POSIX scripts should not use bash-specific features
> * Fix suggestions from shellcheck
> ([https://github.com/apache/maven-wrapper/pull/74])
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
